Merged
Conversation
Contributor
Author
|
This addressed issue #74. The project now builds successfully on Mac. CPack configurations were specific to Debian Linux. I can configure it for macOS as well. |
Treata11
added a commit
to Treata11/delta-studio
that referenced
this pull request
Aug 28, 2024
Adjusted the errors of `safestringlib` on macOS referenced at intel/safestringlib#75; Included the macOS's OpenGL Binaries & headers in the scope of the project; Added `glad` extension-loader library; Removed the references of `Metal-Cpp` libs from the CMake config as they are no longer needed (The chosen renderer for the port is OpenGL as for now).
|
bump bump! |
|
@Treata11 - could you sync your patch forward to match the main branch too? |
Contributor
Author
|
@ausyskin I hate to bother, but is there anything else needed in this PR? |
Closed
ausyskin
reviewed
Mar 12, 2025
ausyskin
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying
CMakeLists.txtconfiguration with Conditional compilation to build the project on OSX as well as Linux.